Normalize path before checking if path should be ignored #7080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Bug 🪲
Configuration
Pierre-Sassoulas
requested changes
Jun 28, 2022
Yes working on that :-) |
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
for more information, see https://pre-commit.ci
Pierre-Sassoulas
approved these changes
Jun 28, 2022
|
Thank you @Pierre-Sassoulas for your review! |
Pull Request Test Coverage Report for Build 2578259595
💛 - Coveralls |
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit c744a53 |
Pierre-Sassoulas
added
Backported
and removed
Needs backport
Pierre-Sassoulas
added a commit
to Pierre-Sassoulas/pylint
that referenced
this pull request
Jun 29, 2022
…7080) Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Pierre-Sassoulas
added a commit
that referenced
this pull request
Jun 29, 2022
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Path should be normalized before checking if it should be ignored. E.g. paths
Are the same path. All paths are normalized before checking so creating ignore regex is more straightforward.
See https://docs.python.org/3/library/os.path.html#os.path.normpath for details.
Closes #6964