Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of quoted init-hook #7010

Merged
merged 2 commits into from Jun 23, 2022
Merged

Fix handling of quoted init-hook #7010

merged 2 commits into from Jun 23, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #7006.

@DanielNoord DanielNoord added Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer Regression labels Jun 23, 2022
@DanielNoord DanielNoord added this to the 2.14.4 milestone Jun 23, 2022
@coveralls
Copy link

coveralls commented Jun 23, 2022 •
edited

Pull Request Test Coverage Report for Build 2549305358

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.339%
Totals Coverage Status
Change from base Build 2548951469: 0.0%
Covered Lines: 16649
Relevant Lines: 17463
💛 - Coveralls

@github-actions

This comment has been minimized.

Sign in to view
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice elegant test ! 👌

@DanielNoord @jacobtylerwalls
Update tests/config/functional/ini/pylintrc_with_quoted_init_hook.ini
0e52f6a 
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@DanielNoord DanielNoord merged commit 9db9b4a into pylint-dev:main Jun 23, 2022
@DanielNoord DanielNoord deleted the init-hook branch June 23, 2022 13:12
@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 0e52f6a

@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Jun 29, 2022
Pierre-Sassoulas pushed a commit to Pierre-Sassoulas/pylint that referenced this pull request Jun 29, 2022
@DanielNoord @jacobtylerwalls @Pierre-Sassoulas
Fix handling of quoted init-hook (pylint-dev#7010)
09992d1 
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Pierre-Sassoulas pushed a commit that referenced this pull request Jun 29, 2022
@DanielNoord @jacobtylerwalls @Pierre-Sassoulas
Fix handling of quoted init-hook (#7010)
b379ef3 
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes

Assignees
No one assigned
Labels
Backported Regression
Projects
None yet
Milestone
2.14.4
Development

Successfully merging this pull request may close these issues.

init-hook no longer supports quoted code
4 participants
@DanielNoord @coveralls @Pierre-Sassoulas @jacobtylerwalls