Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined-variable for __class__ in inner methods #6957

Merged
merged 1 commit into from Jun 15, 2022
Merged

Fix undefined-variable for __class__ in inner methods #6957

merged 1 commit into from Jun 15, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Write a good description on what the PR does.
  • Add an entry to the change log describing the change in
    doc/whatsnew/2/2.15/index.rst (or doc/whatsnew/2/2.14/full.rst
    if the change needs backporting in 2.14). If necessary you can write
    details or offer examples on how the new change is supposed to work.
  • If you used multiple emails or multiple names when contributing, add your mails
    and preferred name in script/.contributors_aliases.json

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #4032.

@DanielNoord DanielNoord added Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer False Positive 🦟 A message is emitted but nothing is wrong with the code labels Jun 15, 2022
@DanielNoord DanielNoord added this to the 2.14.3 milestone Jun 15, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2502518770

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.552%
Totals Coverage Status
Change from base Build 2501912757: 0.0%
Covered Lines: 16413
Relevant Lines: 17177
💛 - Coveralls

@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 461cdc0

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 1242e91 into pylint-dev:main Jun 15, 2022
@DanielNoord DanielNoord deleted the class branch June 15, 2022 21:57
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Jun 18, 2022
Pierre-Sassoulas pushed a commit to Pierre-Sassoulas/pylint that referenced this pull request Jun 18, 2022
@DanielNoord @Pierre-Sassoulas
Fix undefined-variable for __class__ in inner methods (pylint…
5a22a6a 
…-dev#6957)
Pierre-Sassoulas pushed a commit that referenced this pull request Jun 18, 2022
@DanielNoord @Pierre-Sassoulas
Fix undefined-variable for __class__ in inner methods (#6957)
fb6be59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Backported False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.14.3
Development

Successfully merging this pull request may close these issues.

Special reference __class__ is considered undefined in nested lexical scope.
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas