Fix false positive for useless-super-delegation for variadics
#6949
Conversation
DanielNoord
added
Bug 🪲
False Positive 🦟
Pull Request Test Coverage Report for Build 2501904284
💛 - Coveralls |
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
added
the
Needs backport
|
|
||
| class Sub(Super): | ||
| def __init__(self, a, b): | ||
| super().__init__(a, b) |
There was a problem hiding this comment.
How about when the first argument is required? I see the useless-super-delegation for this:
class Super:
def __init__(self, *args):
self.args = args
class Sub(Super):
def __init__(self, a, *args):
super().__init__(a, *args)There was a problem hiding this comment.
So you would want this to raise whenever there is only a variadic in super() and one or more positional in child?
There was a problem hiding this comment.
@DanielNoord that's exactly it. It's just a variation of the original issue which someone may encounter.
There was a problem hiding this comment.
@mbyrnepr2 Let me know what you think of this!
There was a problem hiding this comment.
I think that will work @DanielNoord. I haven't time and haven't played with other variations but I think it's good to go. Thanks!
There was a problem hiding this comment.
Oh one thing is perhaps the comment on line 1279 is a bit inaccurate or hard to understand the underlying intention?
This comment has been minimized.
This comment has been minimized.
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit d70ea49 |
Pierre-Sassoulas
added
Backported
and removed
Needs backport
doc/whatsnew/2/2.15/index.rst(ordoc/whatsnew/2/2.14/full.rstif the change needs backporting in 2.14). If necessary you can write
details or offer examples on how the new change is supposed to work.
and preferred name in
script/.contributors_aliases.jsonType of Changes
Description
Closes #2270.