Fixed misinterpreted modulo sign for consider-using-f-string
#6914
+31
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a % is not a string.
DanielNoord
approved these changes
Jun 11, 2022
jacobtylerwalls
added
Needs backport
jacobtylerwalls
requested changes
Jun 11, 2022
There was a problem hiding this comment.
Thanks for the fix! It needs just a bit of hardening against some possible crashes:
(1, 2) % 'garbage'pylint crashed with a AstroidError and with the following stacktrace:
Traceback (most recent call last):
File "/Users/.../pylint/pylint/checkers/refactoring/recommendation_checker.py", line 398, in _detect_replacable_format_call
if not isinstance(node.parent.left.value, str):
File "/Users/.../astroid/astroid/bases.py", line 119, in __getattr__
return getattr(self._proxied, name)
AttributeError: 'ClassDef' object has no attribute 'value'
Pull Request Test Coverage Report for Build 2480190206
💛 - Coveralls |
jacobtylerwalls
changed the title
consider-using-f-stringconsider-using-f-string
…value it can't be a str
|
🤖 Effect of this PR on checked open source code: 🤖 Effect on pandas:
This comment was generated for commit a94e214 |
jacobtylerwalls
approved these changes
Jun 11, 2022
Pierre-Sassoulas
approved these changes
Jun 11, 2022
DanielNoord
reviewed
Jun 12, 2022
| @@ -394,6 +394,12 @@ def _detect_replacable_format_call(self, node: nodes.Const) -> None: | |||
| if "\\" in node.parent.right.as_string(): | |||
| return | |||
|
|
|||
| # If % applied to another type than str, it's modulo and can't be replaced by formatting | |||
| if not hasattr(node.parent.left, "value") or not isinstance( | |||
There was a problem hiding this comment.
In the future I think it is better to test for the class of left with an isinstance. That's a little more robust and explicit about what we are checking for here.
Pierre-Sassoulas
added
Backported
and removed
Needs backport
Pierre-Sassoulas
pushed a commit
to Pierre-Sassoulas/pylint
that referenced
this pull request
Jun 15, 2022
…int-dev#6914) * Fixed a false positive in consider-using-f-string if the left side of a % is not a string. * consider-using-f-string: if left side of a \% does not have the attr value it can't be a str
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jun 15, 2022
* Fixed a false positive in consider-using-f-string if the left side of a % is not a string. * consider-using-f-string: if left side of a \% does not have the attr value it can't be a str
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fixed a false positive in
consider-using-f-stringif the left side of a%is not a string.Closes False positive for
consider-using-f-stringwhen using modulo operator on a string #6689