Better target DeprecationWarnings in pyreverse #6869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
pyreverse
Pull Request Test Coverage Report for Build 2445354698
💛 - Coveralls |
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉This comment was generated for commit edca764 |
Pierre-Sassoulas
approved these changes
Jun 6, 2022
Pierre-Sassoulas
added
the
Needs backport
DudeNr33
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
Thanks for catching that. 👍
The way it was implemented by me was actually wrong, as the warning also triggered when no __implements__ attribute was present. So you'd get the warning every time when running pyreverse with warnings enabled.
While I added a unit test to check if the DeprecationWarning is emitted if __implements__ exists, I forgot to add a test case for the case of a "normal" class...
Pierre-Sassoulas
added
Backported
and removed
Needs backport
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jun 6, 2022
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jun 6, 2022
jacobtylerwalls
added a commit
to jacobtylerwalls/pylint
that referenced
this pull request
Nov 20, 2022
Follow-up to pylint-dev#6869
jacobtylerwalls
added a commit
to jacobtylerwalls/pylint
that referenced
this pull request
Nov 20, 2022
Follow-up to pylint-dev#6869
Pierre-Sassoulas
added a commit
that referenced
this pull request
Nov 23, 2022
* Catch DeprecationWarning in pyreverse Follow-up to #6869 * Patch use of deprecated `astroid.node_classes` in test * Ignore DeprecationWarning in test_parseable_output_regression Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Reduces 26 instances of this
DeprecationWarningin the suite to 1. (That 1 will need a substantive fix.)Refs #6713