Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bad-option-value] Use the right confidence and refactor message #6829

Merged
merged 2 commits into from Jun 4, 2022
Merged

[bad-option-value] Use the right confidence and refactor message #6829

merged 2 commits into from Jun 4, 2022

Conversation

Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented Jun 4, 2022 •
edited

Type of Changes

Type
✓ 🔨 Refactoring

Description

All the refactoring and betterment done during #6824 so we only have the new message in the final MR. Follow-up to #6826

@Pierre-Sassoulas Pierre-Sassoulas added Documentation 📗 Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer Maintenance Discussion or action around maintaining pylint or the dev workflow labels Jun 4, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.14.1 milestone Jun 4, 2022
@coveralls
Copy link

coveralls commented Jun 4, 2022 •
edited

Pull Request Test Coverage Report for Build 2439735252

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.53%
Totals Coverage Status
Change from base Build 2439498818: 0.0%
Covered Lines: 16328
Relevant Lines: 17092
💛 - Coveralls

@github-actions

This comment has been minimized.

Sign in to view
DanielNoord
DanielNoord approved these changes Jun 4, 2022
View reviewed changes
pylint/lint/pylinter.py Outdated Show resolved Hide resolved
@Pierre-Sassoulas @DanielNoord
Update pylint/lint/pylinter.py
6dedf43 
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
@Pierre-Sassoulas Pierre-Sassoulas merged commit 8a9aa13 into main Jun 4, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the bad-option-value-confidence branch June 4, 2022 13:38
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2022

🤖 Effect of this PR on checked open source code: 🤖

Effect on astroid:
The following messages are now emitted:

  1. bad-option-value:
    Bad option value for 'disable', expected a valid pylint message and got 'Ellipsis'
    https://github.com/PyCQA/astroid/blob/main/astroid/__init__.py#L91
  2. bad-option-value:
    Bad option value for 'disable', expected a valid pylint message and got 'Ellipsis'
    https://github.com/PyCQA/astroid/blob/main/astroid/node_classes.py#L9
  3. bad-option-value:
    Bad option value for 'disable', expected a valid pylint message and got 'Ellipsis'
    https://github.com/PyCQA/astroid/blob/main/astroid/nodes/__init__.py#L15

The following messages are no longer emitted:

  1. bad-option-value:
    Bad option value for disable. Don't recognize message Ellipsis.
    https://github.com/PyCQA/astroid/blob/main/astroid/__init__.py#L91
  2. bad-option-value:
    Bad option value for disable. Don't recognize message Ellipsis.
    https://github.com/PyCQA/astroid/blob/main/astroid/node_classes.py#L9
  3. bad-option-value:
    Bad option value for disable. Don't recognize message Ellipsis.
    https://github.com/PyCQA/astroid/blob/main/astroid/nodes/__init__.py#L15

This comment was generated for commit 6dedf43

Pierre-Sassoulas added a commit that referenced this pull request Jun 5, 2022
@Pierre-Sassoulas @DanielNoord
[bad-option-value] Use the right confidence and refactor message (#6829)
44e77e7 
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Jun 5, 2022
Pierre-Sassoulas added a commit that referenced this pull request Jun 6, 2022
@Pierre-Sassoulas @DanielNoord
[bad-option-value] Use the right confidence and refactor message (#6829)
0b41dfc 
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Backported Documentation 📗 Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.14.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pierre-Sassoulas @coveralls @DanielNoord