Fix 'object has no attribute additional_builtins' #6410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
force-pushed
the
fix-issue-6408
branch
from
4e4d20e
to
bc11f90
Compare
DanielNoord
reviewed
Apr 20, 2022
| @@ -71,7 +71,8 @@ cherry-picked on the maintenance branch. | |||
| - Bump the version and release by using `tbump X.Y-1.Z --no-push`. (For example: | |||
| `tbump 2.3.5 --no-push`) | |||
| - Check the result visually with `git show`. | |||
| - Push the tag. | |||
| - Open a merge request to run the CI tests for this branch | |||
There was a problem hiding this comment.
😄
Although tests did seem to pass on the branch?
There was a problem hiding this comment.
😅 No, the check on non default branches are limited it's only pre-commit that is launched (unless we open a MR).
There was a problem hiding this comment.
Sorry for not noticing/pointing out during review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
We cherry picked a fix without testing on all python versions in the CI.
Closes #6408