Only emit lru-cache-decorating-method when maxsize is None
#6181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
Bug 🪲
Needs backport
Pull Request Test Coverage Report for Build 2094472459
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
Apr 4, 2022
jacobtylerwalls
approved these changes
Apr 5, 2022
|
Moved the rename into this PR/ |
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Pierre-Sassoulas
approved these changes
Apr 5, 2022
| @@ -80,6 +80,11 @@ Release date: TBA | |||
| Closes #6069 | |||
| Closes #6136 | |||
|
|
|||
| * ``lru-cache-decorating-method`` has been renamed to ``cache-max-size-none`` and | |||
There was a problem hiding this comment.
maxsize is spelled as one word in the argument. What about cache-maxsize-none?
There was a problem hiding this comment.
If we keep it like max-size we can potentially reuse later on for another function. But I'm fine with either!
There was a problem hiding this comment.
I don't feel strongly. Happy to keep this way.
jacobtylerwalls
approved these changes
Apr 5, 2022
Pierre-Sassoulas
removed
the
Needs backport
Pierre-Sassoulas
added a commit
that referenced
this pull request
Apr 6, 2022
#6181) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com> Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/whatsnew/<current release.rst>.Type of Changes
Description
Closes #6180.