Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive for the unnecessary-ellipsis checker #6039

Merged
merged 4 commits into from Mar 30, 2022
Merged

Fix false positive for the unnecessary-ellipsis checker #6039

merged 4 commits into from Mar 30, 2022

Conversation

mbyrnepr2
Copy link
Member

@mbyrnepr2 mbyrnepr2 commented Mar 29, 2022 •
edited by Pierre-Sassoulas

Type of Changes

Type
✓ 🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Description

Fix false positive for the unnecessary-ellipsis checker when an ellipsis is used in a lambda expression.

Closes #6036

Mark Byrne and others added 2 commits March 29, 2022 20:37
@mbyrnepr2 mbyrnepr2 changed the title Fix false positive for the unnecessary-ellipsis checker when an… Fix false positive for the unnecessary-ellipsis checker Mar 29, 2022
@Pierre-Sassoulas Pierre-Sassoulas added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Mar 29, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.4 milestone Mar 29, 2022
@Pierre-Sassoulas Pierre-Sassoulas added the Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer label Mar 29, 2022
@coveralls
Copy link

coveralls commented Mar 29, 2022 •
edited

Pull Request Test Coverage Report for Build 2060481801

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.173%
Totals Coverage Status
Change from base Build 2059373291: 0.0%
Covered Lines: 15418
Relevant Lines: 16372
💛 - Coveralls

@mbyrnepr2 mbyrnepr2 marked this pull request as ready for review March 29, 2022 19:19
@Pierre-Sassoulas
Copy link
Member

Thank you for the quick fix @mbyrnepr2 !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 789a381 into pylint-dev:main Mar 30, 2022
@mbyrnepr2 mbyrnepr2 deleted the 6036_false_positive_uneccessary_ellipsis_checker branch March 30, 2022 20:34
@mbyrnepr2
Copy link
Member Author

No problem @Pierre-Sassoulas. Thank you for helping keeping an eye on things, updating the branch with the needful.

@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Mar 31, 2022
Pierre-Sassoulas added a commit that referenced this pull request Mar 31, 2022
@mbyrnepr2 @Pierre-Sassoulas
Fix false positive for the unnecessary-ellipsis checker (#6039)
5ea03af 
When an ellipsis is used in a lambda expression.

  Closes #6036

Co-authored-by: Mark Byrne <mark.byrne@rabobank.com>
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Backported False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.13.4
Development

Successfully merging this pull request may close these issues.

unnecessary-ellipsis false-positive when using ... in lambda
3 participants
@mbyrnepr2 @coveralls @Pierre-Sassoulas