New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash for `unneccessary-ellipsis` checker #6038

Merged

Pierre-Sassoulas merged 12 commits into pylint-dev:main from mbyrnepr2:6037_crash_unnecessary_ellipsis_checker

Mar 30, 2022

Member

mbyrnepr2 commented Mar 29, 2022 •

edited

Fix crash for unneccessary-ellipsis checker when an ellipsis is used inside of a list.

Closes #6037
Closes #6048

Type of Changes

	Type
✓	🐛 Bug fix
	✨ New feature
	🔨 Refactoring
	📜 Docs

Description

Closes #XXX


          Fix crash for unneccessary-ellipsis checker when an ellipsis is u…

…sed inside of a list.

Closes pylint-dev#6037

mbyrnepr2 force-pushed the 6037_crash_unnecessary_ellipsis_checker branch from 3c95269 to 3468344 Compare

March 29, 2022 18:21


          [pre-commit.ci] auto fixes from pre-commit.com hooks

c966366

for more information, see https://pre-commit.ci

Pierre-Sassoulas added Needs backport Crash 💥 labels

Pierre-Sassoulas added this to the 2.13.4 milestone

coveralls commented Mar 29, 2022 •

edited

Pull Request Test Coverage Report for Build 2061576588

0 of 0 changed or added relevant lines in 0 files are covered.
44 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.03%) to 94.206%

Files with Coverage Reduction	New Missed Lines	%
pylint/config/option_manager_mixin.py	19	89.45%
pylint/lint/run.py	25	73.76%

Totals
Change from base Build 2059373291:	0.03%
Covered Lines:	15414
Relevant Lines:	16362

💛 - Coveralls


          Move changelog to 2.13.4

0cccbed

mbyrnepr2 marked this pull request as ready for review

March 29, 2022 19:32

Mark Byrne and others added 9 commits

March 30, 2022 00:10


          Ignore unnecessary-ellipsis checker if the ellipsis is inside a

ad13501

container


          [pre-commit.ci] auto fixes from pre-commit.com hooks

f821e3e

for more information, see https://pre-commit.ci


          Remove breakpoint

2e1200b


          Remove empty line from Changelog

75379a8


          [pre-commit.ci] auto fixes from pre-commit.com hooks

332390d

for more information, see https://pre-commit.ci


          Update Changelog; Also closes pylint-dev#6048.

c19f613


          Merge branch '6037_crash_unnecessary_ellipsis_checker' of https://git…

035565a

…hub.com/mbyrnepr2/pylint into 6037_crash_unnecessary_ellipsis_checker


          Format Changelog entry

6acd130


          Update functional test namings

464c8ec

mbyrnepr2 closed this

mbyrnepr2 reopened this

DanielNoord approved these changes

View reviewed changes

Pierre-Sassoulas approved these changes

View reviewed changes

Pierre-Sassoulas merged commit d12c770 into pylint-dev:main

mbyrnepr2 deleted the 6037_crash_unnecessary_ellipsis_checker branch

March 30, 2022 20:34

Pierre-Sassoulas added Backported and removed Needs backport labels

Pierre-Sassoulas added a commit that referenced this pull request


          Fix crash for unneccessary-ellipsis checker (#6038)

8b20590

When an ellipsis is used inside of a list or inside a container

Closes #6037

Co-authored-by: Mark Byrne <mark.byrne@rabobank.com>
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment