Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include testing_pylintrc in source and wheel distributions #6029

Merged

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Mar 29, 2022

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #6028. testing_pylintrc wasn't being included in package distributions.
This should fix running tests via tox (this is where I encountered it) and any uses of pylint.testutils

image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2058127529

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.154%

Totals Coverage Status
Change from base Build 2057470749: 0.0%
Covered Lines: 15334
Relevant Lines: 16286

πŸ’› - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Mar 29, 2022
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.14.0, 2.13.4 Mar 29, 2022
@Pierre-Sassoulas Pierre-Sassoulas added Crash πŸ’₯ A bug that makes pylint crash Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Mar 29, 2022
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it was that easy...

Thanks @jpy-git

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy pasting the comment I put on the wrong issue:

There's another solution: it's to generate the default value at runtime in the testutil if the file do not exists. As those tests class are used only by downstream library maintainer this file is very seldom required so not adding it to the packaging at all will be better 99,95% of the time.

@DanielNoord
Copy link
Collaborator

Copy pasting the comment I put on the wrong issue:

There's another solution: it's to generate the default value at runtime in the testutil if the file do not exists. As those tests class are used only by downstream library maintainer this file is very seldom required so not adding it to the packaging at all will be better 99,95% of the time.

The file is relatively small so won't add much. I think having it as a separate file makes the code much cleaner.
If we really want to worry about distrubution size we should make all testutils optional.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 2885eef into pylint-dev:main Mar 29, 2022
@jpy-git jpy-git deleted the testing_pylintrc_packaging branch March 29, 2022 15:08
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported Crash πŸ’₯ A bug that makes pylint crash Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure to package the pylintrc from testutils
4 participants