Add regression test for #5982 #5988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
the
Needs astroid update
jacobtylerwalls
added
the
Needs backport
|
Hmm, there's a fail in 3.6, but it's end of life. We're effectively maintaining 3.6 code as long as we do not release 2.14 with #5921. It may make sense to release 2.14 now with the few features it has in order to not maintain python 3.6 any longer. |
cdce8p
reviewed
Mar 26, 2022
tests/functional/u/used/used_before_assignment_type_annotations.py
Outdated
Show resolved
Hide resolved
|
Ha, no I just need to set min version on the test -- forgot that |
Merged
4 tasks
Pierre-Sassoulas
approved these changes
Mar 26, 2022
|
Please see comment in |
Pull Request Test Coverage Report for Build 2045992410
💛 - Coveralls |
|
Merging as the discussion in pylint-dev/astroid#1489 (comment) came to an agreement that the fix is correct. |
Pierre-Sassoulas
removed
the
Needs backport
Pierre-Sassoulas
added a commit
that referenced
this pull request
Mar 27, 2022
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #5982
Refs pylint-dev/astroid#1489