Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move various tests from TestTypeChecker to functional tests #5455

Merged
merged 4 commits into from Dec 2, 2021
Merged

Move various tests from TestTypeChecker to functional tests #5455

merged 4 commits into from Dec 2, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

The two tests not covered by this PR or #5453 will need to stay.

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Dec 2, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1532129533

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.52%
Totals Coverage Status
Change from base Build 1531897995: 0.0%
Covered Lines: 14028
Relevant Lines: 15000
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.12.2 milestone Dec 2, 2021
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job detecting the duplicate !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 35813de into pylint-dev:main Dec 2, 2021
@DanielNoord DanielNoord deleted the move-unittests-16 branch December 2, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.12.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas