Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move no-member tests from TestTypeChecker #5453

Merged
merged 11 commits into from Dec 3, 2021
Merged

Move no-member tests from TestTypeChecker #5453

merged 11 commits into from Dec 3, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Dec 2, 2021
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pierre-Sassoulas Pierre-Sassoulas modified the milestone: 2.12.2 Dec 2, 2021
@Pierre-Sassoulas
Copy link
Member

Removing 2.12.2 milestone because the tests are failing and there's no urgency to refactor this for 2.12.2.

@coveralls
Copy link

coveralls commented Dec 2, 2021 •
edited

Pull Request Test Coverage Report for Build 1531632454

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 93.515%
Files with Coverage Reduction New Missed Lines %
pylint/checkers/typecheck.py 1 94.9%
Totals Coverage Status
Change from base Build 1520446193: -0.007%
Covered Lines: 14003
Relevant Lines: 14974
💛 - Coveralls

@DanielNoord DanielNoord mentioned this pull request Dec 2, 2021
Merged
2 tasks
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.12.2 milestone Dec 3, 2021
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pierre-Sassoulas Pierre-Sassoulas merged commit e14596e into pylint-dev:main Dec 3, 2021
@DanielNoord DanielNoord deleted the move-unittests-15 branch December 3, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.12.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielNoord @Pierre-Sassoulas @coveralls