Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Sphinx docstrings out of TestParamDocChecker #5450

Merged
merged 1 commit into from Dec 3, 2021
Merged

Move Sphinx docstrings out of TestParamDocChecker #5450

merged 1 commit into from Dec 3, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

@Pierre-Sassoulas I'm so sorry my git history was totally messed up and I couldn't retrieve the individual commits. If you don't think this is reviewable let me know and I'll redo this.

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Dec 1, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1526616439

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.522%
Totals Coverage Status
Change from base Build 1520446193: 0.0%
Covered Lines: 14004
Relevant Lines: 14974
💛 - Coveralls

@DanielNoord
Copy link
Collaborator Author

@Pierre-Sassoulas Would you mind putting this in 2.12.2 so I can fix #5406 for 2.12.2 while using functional tests?

@DanielNoord DanielNoord mentioned this pull request Dec 2, 2021
Closed
@DanielNoord DanielNoord added this to the 2.12.2 milestone Dec 3, 2021
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't think this is reviewable let me know and I'll redo this.

Let's not be ideological about it, looks like it would take a lot of time 😄

Everything looks fine, and there's 60 lines we won't have to maintain anymore on top of that.

@Pierre-Sassoulas Pierre-Sassoulas merged commit bce059a into pylint-dev:main Dec 3, 2021
@DanielNoord DanielNoord deleted the move-unittests-14 branch December 3, 2021 12:48
@DanielNoord
Copy link
Collaborator Author

Thanks! I'll be more mindful for the next ones! PR for #5406 coming in a couple of minutes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.12.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas