-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update outdated class name in "How to Write a Checker" test example #5449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is still a WIP until I finish all these open tasks for submitting a PR:
|
Pull Request Test Coverage Report for Build 1535144340
💛 - Coveralls |
I'm a bit unsure if and how to go about adding an entry to // edit: Nevermind, I just looked through your contributing document, which tells me a changelog entry is not necessary in this case:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok if there is no changelog for this one, thank you for making the documentation better and congrat on becoming a contributor :) For the next MR you'll be trusted enough to run the github action without approval 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know about this part of the docs
. Seems like we might want to update it as it would be a source of new unittests instead of functional tests. @Pierre-Sassoulas
The change itself looks good though. Thanks! 😄
pylint.testutils.Message
got first renamed topylint.testutils.TestMessage
in 49776ac and finally renamed topylint.testutils.MessageTest
in 24cbf8c.Documentation was not updated to use the new class name.
Type of Changes
Description