-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add documentation for primer and convert to command line option #5387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 1502943571
💛 - Coveralls |
tests/conftest.py
Outdated
|
||
def pytest_addoption(parser) -> None: | ||
parser.addoption( | ||
"--primer_stdlib", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"--primer_stdlib", | |
"--primer-stdlib", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't mark with @pytest.mark.primer-stdlib
so I thought I would keep consistency throughout the functions using it. Do you want me to change it anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For CLI option I think the standard is -
tests/conftest.py
Outdated
help="Run primer stdlib tests", | ||
) | ||
parser.addoption( | ||
"--primer_external", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"--primer_external", | |
"--primer-external", |
There's a lot of other place to change, but it's hard to do in github.
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
We still need to add the mark to the |
Wasn't the point of adopt that primer were not launched by default ? What am I missing ? |
This has been fixed with dab1e03
With this implementation Basically instead of not selecting the mark by default (and therefore not showing up in test collection) this makes it so the mark is skipped by default. |
Type of Changes
Description
Based on https://docs.pytest.org/en/latest/example/simple.html#control-skipping-of-tests-according-to-command-line-option
Because we can remove the standard
addopts
IDEs like VS Code will now actually find all tests in our test suite, but will just skip them when running normally. Makes it easier (at least for those on VS Code) to explore all tests.Ticks of two points from #5306