Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate and fix existing use-set-for-membership checks #5379

Merged
merged 2 commits into from Nov 25, 2021
Merged

Activate and fix existing use-set-for-membership checks #5379

merged 2 commits into from Nov 25, 2021

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
✓ ✨ New feature
✓ 🔨 Refactoring

Description

Activate use set for membership in pylint, for a small performance gain.

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Nov 23, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.12.1 milestone Nov 23, 2021
@coveralls
Copy link

coveralls commented Nov 23, 2021 •
edited

Pull Request Test Coverage Report for Build 1504157382

  • 45 of 45 (100.0%) changed or added relevant lines in 16 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.5%
Totals Coverage Status
Change from base Build 1504096401: 0.0%
Covered Lines: 13996
Relevant Lines: 14969
💛 - Coveralls

DanielNoord
DanielNoord approved these changes Nov 23, 2021
View reviewed changes
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pierre-Sassoulas Pierre-Sassoulas merged commit e4a1935 into pylint-dev:main Nov 25, 2021
@Pierre-Sassoulas Pierre-Sassoulas deleted the activate-set-membership branch November 25, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.12.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pierre-Sassoulas @coveralls @DanielNoord