Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move methods to BaseLayout #5015

Merged
merged 2 commits into from Sep 16, 2021
Merged

Move methods to BaseLayout #5015

merged 2 commits into from Sep 16, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

Quick and easy change as suggested by myself in #5004 (comment)
/CC @Pierre-Sassoulas

@coveralls
Copy link

coveralls commented Sep 15, 2021 •
edited

Pull Request Test Coverage Report for Build 1239343699

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 93.093%
Totals Coverage Status
Change from base Build 1239164391: -0.001%
Covered Lines: 13289
Relevant Lines: 14275
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Sep 16, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.11.0 milestone Sep 16, 2021
@Pierre-Sassoulas Pierre-Sassoulas merged commit 14f4db5 into pylint-dev:main Sep 16, 2021
@DanielNoord DanielNoord deleted the baselayout branch September 16, 2021 07:17
@DanielNoord DanielNoord mentioned this pull request Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas