Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change lines to lists #5009

Merged
merged 3 commits into from Sep 14, 2021
Merged

Change lines to lists #5009

merged 3 commits into from Sep 14, 2021

Conversation

DanielNoord
Copy link
Collaborator

/CC @cdce8p

This changes some occurrences of lines to become lists

@DanielNoord DanielNoord mentioned this pull request Sep 14, 2021
Merged
2 tasks
DanielNoord
DanielNoord commented Sep 14, 2021
View reviewed changes
pylint/checkers/base.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Sep 14, 2021 •
edited

Pull Request Test Coverage Report for Build 1235194292

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.075%
Totals Coverage Status
Change from base Build 1234708774: 0.0%
Covered Lines: 13253
Relevant Lines: 14239
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas reviewed Sep 14, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there's a reason for this change, that I don't know of :)

pylint/checkers/base.py Outdated Show resolved Hide resolved
cdce8p
cdce8p approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Btw. list[str] requires 3.9 or from __future__ import annotations. List[str] would have worked.

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.11.0 milestone Sep 14, 2021
@cdce8p
Copy link
Member

cdce8p commented Sep 14, 2021

@Pierre-Sassoulas See the discussion here: #4973 (comment)

@DanielNoord
Copy link
Collaborator Author

Yeah I was too quick and then I thought "wait this is implicit"!

@DanielNoord @Pierre-Sassoulas
Update pylint/checkers/base.py
d79b008 
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Sep 14, 2021
@cdce8p cdce8p merged commit 0687d5c into pylint-dev:main Sep 14, 2021
@DanielNoord DanielNoord deleted the lines branch September 15, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@cdce8p cdce8p cdce8p approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DanielNoord @coveralls @cdce8p @Pierre-Sassoulas