Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyreverse: has-a relationships for type-hinted arguments #4744

Closed
mbyrnepr2 opened this issue Jul 25, 2021 · 0 comments · Fixed by #4745
Closed

pyreverse: has-a relationships for type-hinted arguments #4744

mbyrnepr2 opened this issue Jul 25, 2021 · 0 comments · Fixed by #4745
Labels
Enhancement ✨ Improvement to a component
Milestone
2.10.0

Comments

@mbyrnepr2
Copy link
Member

Thanks for your work on this @mbyrnepr2 .

Quick question: It looks like the use case described in the first post works, but it doesn't show the "has-a" relationship the same way it would for a class instance defined within.

For example:

Here, where the instance of class B is passed to A's initializer, A's "box" shows it has a member of type B, but doesn't show this graphically.
image

Here, where an instance of B is created in class A's initializer, it does show it graphically.
image

Is there a way have this visual "has a" relationship to work for type-hinted, passed, arguments?

Originally posted by @BenBlumer in #1548 (comment)
mbyrnepr2 added a commit to mbyrnepr2/pylint that referenced this issue Jul 25, 2021
@mbyrnepr2
Pyreverse - Show class has-a relationships inferred from type-hints
846415d 
Closes pylint-dev#4744
@mbyrnepr2 mbyrnepr2 mentioned this issue Jul 25, 2021
Merged
4 tasks
@Pierre-Sassoulas Pierre-Sassoulas added the Enhancement ✨ Improvement to a component label Jul 25, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.10.0 milestone Jul 26, 2021
mbyrnepr2 added a commit to mbyrnepr2/pylint that referenced this issue Jul 30, 2021
@mbyrnepr2
Pyreverse - Show class has-a relationships inferred from type-hints
70b36d4 
- Update Changelog

Closes pylint-dev#4744
mbyrnepr2 added a commit to mbyrnepr2/pylint that referenced this issue Jul 30, 2021
@mbyrnepr2
Pyreverse - Show class has-a relationships inferred from type-hints
7744a27 
Add tests
- Unittest to check returned type is a ClassDef
- Update pyreverse test/data to include the scenario of a relation
inferred from a type-hint

Closes pylint-dev#4744
Pierre-Sassoulas added a commit that referenced this issue Jul 30, 2021
@mbyrnepr2 @Pierre-Sassoulas
Handle has-a relationships for type-hinted arguments in class diagrams (

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b71be8a 
#4745)

* Pyreverse - Show class has-a relationships inferred from type-hints

Closes #4744

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
cdce8p added a commit to cdce8p/pylint that referenced this issue Aug 1, 2021
@cdce8p
PR 4783 - nested attributes
b0164a6 
Squashed commit of the following:

commit 49c4bba
Author: Yu Shao, Pang <p.yushao2@gmail.com>
Date:   Sun Aug 1 19:56:51 2021 +0800

    Fix crash for `unused-private-member` when there are nested attributes

commit 2ad8247
Merge: 8ceb26d 1d09bc8
Author: yushao2 <36848472+yushao2@users.noreply.github.com>
Date:   Sun Aug 1 20:13:05 2021 +0800

    Merge pull request pylint-dev#4709 from yushao2/fix-unused-private-member-4673

    [unused-private-member] add logic for checking nested functions

commit 1d09bc8
Author: Yu Shao, Pang <p.yushao2@gmail.com>
Date:   Sun Aug 1 20:03:42 2021 +0800

    update pr based on review

commit a4198cd
Author: Yu Shao, Pang <p.yushao2@gmail.com>
Date:   Sun Aug 1 19:21:36 2021 +0800

    Update pr based on review

commit c8b2cbb
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Sun Jul 25 05:20:42 2021 +0000

    [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci

commit 4ffea0b
Author: Yu Shao, Pang <p.yushao2@gmail.com>
Date:   Sun Jul 25 13:12:29 2021 +0800

    Update pr based on review

commit e4d6243
Author: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Date:   Sun Jul 18 17:23:31 2021 +0200

    Remove empty line

commit cce5833
Author: Yu Shao, Pang <p.yushao2@gmail.com>
Date:   Sun Jul 18 22:40:54 2021 +0800

    update PR based on comments

commit 712dc2b
Author: Yu Shao, Pang <p.yushao2@gmail.com>
Date:   Wed Jul 14 16:42:25 2021 +0800

    [unused-private-member] add logic for checking nested functions

    also, improve error message for nested functions

commit 8ceb26d
Author: Michal Vasilek <michal@vasilek.cz>
Date:   Sun Aug 1 08:14:58 2021 +0200

    Fix IsADirectoryError in tests/lint/unittest_lint (pylint-dev#4781)

    pylintd is a directory, so os.remove throws IsADirectoryError

commit a31e6bc
Author: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Date:   Sat Jul 31 11:21:46 2021 +0200

    Add documentation for useless-suppression

    Closes pylint-dev#4757

commit b71be8a
Author: Mark Byrne <31762852+mbyrnepr2@users.noreply.github.com>
Date:   Fri Jul 30 20:21:02 2021 +0200

    Handle has-a relationships for type-hinted arguments in class diagrams (pylint-dev#4745)

    * Pyreverse - Show class has-a relationships inferred from type-hints

    Closes pylint-dev#4744

    Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>

commit 5e5f48d
Author: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
Date:   Thu Jul 29 23:44:30 2021 +0200

    Add ``forgotten-debug-statement`` checker (pylint-dev#4771)

    * Add ``no-breakpoint`` checker this adds a checker for calls to ``breakpoint()``, ``pdb.set_trace()``, or ``sys.breakpointhook()``.

    Closes pylint-dev#3692

    Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
    Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement ✨ Improvement to a component
Projects
None yet
Milestone
2.10.0
Development

Successfully merging a pull request may close this issue.

Handle has-a relationships for type-hinted arguments in class diagrams mbyrnepr2/pylint
2 participants
@Pierre-Sassoulas @mbyrnepr2