New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github issue forms and densify some templates #4742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
If you like, take a look at the BUG
template for setuptools
: https://github.com/pypa/setuptools/issues/new?assignees=&labels=bug%2CNeeds+Triage&template=bug-report.yml&title=%5BBUG%5D+
Given a file `a.py`: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines are not really necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I think it nudges the reporter to provide a reproducible example and I really like having a reproducible example, I think I'll keep that.
label: What is the command used and its actual output ? | ||
description: Please provide the command used and the current output | ||
value: | | ||
Result of `pylint a.py`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is also not really necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very often the reporter do not gives the pylint output and just gives a general description "I don't like the output", I'll also keep this, that as it nudges reporter to make a report that permits to understand the problem without thinking too much or linting the code ourselves.
4b18c34
to
20b729e
Compare
07cf835
to
0a43a26
Compare
Thank you for the review and the original idea @cdce8p, I think these new forms are great ! |
Type of Changes
Description
This start using the form template that are still in beta. Result can be seen and tested here: https://github.com/Pierre-Sassoulas/pylint/issues/new/choose
Closes #4735