Fix various problems with --import-graph filename parsing #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids backwards-incompatible changes. - Raise error if graphvis is not installed (instead of reporting success) - Fix tempfile creation bug when outputfile includes directories - Fix bug when using file extension that isn't 3 characters long - Fix confusing help text - Rename deprecated .dot extension to .gv - Default to .png if no extension is specified
Pierre-Sassoulas
requested changes
Mar 28, 2021
Pierre-Sassoulas
added
Documentation 📗
Enhancement ✨
(and ignore mypy thinking codecs.open() returns an int)
Pierre-Sassoulas
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pre-existing code looks extremely dodgy, but I've tried to avoid making any backwards-incompatible changes while fixing some problems that made it very difficult to work out how to use this option.
Changes:
Type of Changes