Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to allow lower case enum names #4181

Closed
libre-man opened this issue Mar 3, 2021 · 3 comments · Fixed by #4185
Closed

Make it possible to allow lower case enum names #4181

libre-man opened this issue Mar 3, 2021 · 3 comments · Fixed by #4185
Labels
Configuration Related to configuration Proposal 📨

Comments

@libre-man
Copy link

Is your feature request related to a problem? Please describe

With #3834 enums are now required to be in all caps, and seem to be treated equal to normal constants. However, existing code bases can't simply change all enum values, as this backwards incompatible, and adding an ignore to each member is a lot of noise.

Describe the solution you'd like

Add a new regex or option to change the allowed way enum values can look

@Pierre-Sassoulas Pierre-Sassoulas added Proposal 📨 Configuration Related to configuration labels Mar 3, 2021
@cdce8p
Copy link
Member

cdce8p commented Mar 4, 2021

I agree. Adding a new naming style might be the way to go. Maybe something like --class-const-naming-style. This could also be applied to class attributes annotated with Final. @Pierre-Sassoulas What do you think?

http://pylint.pycqa.org/en/latest/user_guide/options.html#predefined-naming-styles

@Pierre-Sassoulas
Copy link
Member

Makes sense !

@cdce8p
Copy link
Member

cdce8p commented Mar 5, 2021

Opened #4185 to add --class-const-naming-style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Configuration Related to configuration Proposal 📨
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants