Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support isort 5 #3722

Closed
dekked opened this issue Jul 4, 2020 · 10 comments · Fixed by #3725
Closed

Support isort 5 #3722

dekked opened this issue Jul 4, 2020 · 10 comments · Fixed by #3725

Comments

@dekked
Copy link

dekked commented Jul 4, 2020

Hello,

isort 5, a new major release which is very much improved, has just been released.

So far, it is not possible to install pylint and isort 5 together.

It would be great if pylint could add support for it :)
@saroad2
Copy link

saroad2 commented Jul 5, 2020

This is much needed! would love to see this sooner than later.

This was referenced Jul 5, 2020
Closed
Merged
@panicstevenson panicstevenson mentioned this issue Jul 5, 2020
Merged
@lbudai lbudai mentioned this issue Jul 6, 2020
Merged
@kmsquire
Copy link

kmsquire commented Jul 6, 2020 •
edited

Excited to see #3725!

One concrete reason to support isort 5 is for compatibility with black. isort 4 and black conflict with each other slightly (PyCQA/isort#694), which makes it challenging to use black and isort 4 (or pylint, which depends on isort 4) together.

Right now in our code base, we have isort 5 and black installed, which keeps the formatting consistent, but have pylint disabled 😢.

@eht16 eht16 mentioned this issue Jul 7, 2020
Closed
@limburgher
Copy link

I maintain both isort and pylint for Fedora, and will be happy to test any proposed fixes.

@saroad2
Copy link

saroad2 commented Jul 8, 2020

Hey @limburgher, it's seems as this issue has been fixed in #3725

@limburgher
Copy link

So it has, thank you!

jloehel added a commit to jloehel/python-logstash-async that referenced this issue Jul 9, 2020
@jloehel
Use isort 4.x
131f24b 
Pylint is not yet compatible with isort 5.x
For more information please visit:
  * pylint-dev/pylint#3722
  * pylint-dev/pylint#3725

Signed-off-by: Jürgen Löhel <juergen.loehel@inlyse.com>
@rohanpm rohanpm mentioned this issue Jul 9, 2020
Closed
@saroad2
Copy link

saroad2 commented Jul 13, 2020

Is there a chance to add this issue to the closest milestone? this issue really important for my use case.

@GilShoshan94 GilShoshan94 mentioned this issue Jul 18, 2020
Closed
linjiX added a commit to linjiX/dotfiles that referenced this issue Jul 23, 2020
@linjiX
[setup] Set 'isort' to 4.3.21 due to 'pylint' confilct with 'isort' 5
e09f40f 
github issue: pylint-dev/pylint#3722
@sandrotosi
Copy link
Contributor

For Debian, it would be extremely important to get #3725 merged and a new pylint release cut out soon: isort 5 was uploaded to our archive, so now pylint is getting removed from our users boxes because it conflicts with isort < 5

:(

@sandrotosi
Copy link
Contributor

(i tried to adapt the #3725 changes to 2.5.3, but there are too many changes in between)

@LocutusOfBorg
Copy link

@sandrotosi I did the work, and attached to the Debian RC bug!

@fbidu fbidu mentioned this issue Aug 8, 2020
Open
@saroad2
Copy link

saroad2 commented Aug 13, 2020

Any progress with this issue? I'm stuck in this situation where I need to choose between pylint and isort because of it.
I cannot use isort4 because of some bugs it causes in my CI/CD process.

For now, I chose pylint over isort because it points out a lot of important bugs and really elevates my code, but I really want to use both. I'm a true believer in clean code, and I try to keep my code as clean as possible. Please help me make that happen!

@MrNaif2018 MrNaif2018 mentioned this issue Aug 13, 2020
Merged
Pierre-Sassoulas pushed a commit that referenced this issue Aug 18, 2020
@dbaty @Pierre-Sassoulas
Support both isort 4 and isort 5
9bc9bdf 
The API of isort 5 (released on 2020-07-04) is completely different.
We must still support isort 4 because isort 5 dropped the
compatibility with Python 3.5, which pylint still supports.

Note about the `known-standard-library` option: it has been included
in pylint for years. Until now, it was mapped with the option of the
same name in isort. However, isort 5 has changed the meaning of this
option (see https://timothycrosley.github.io/isort/docs/upgrade_guides/5.0.0/#known_standard_library).

Most users of pylint want the meaning of the new
`extra-standard-library` option. To avoid a breaking change in pylint,
the `known-standard-library` pylint option is now mapped to
`known-standard-library` in isort 4, and `extra-standard-library` in
isort 5. Users that really want the _new_ meaning of
`known-standard-library` in isort 4 must disable the
`wrong-import-order` check in pylint and run isort manually, outside
of pylint.

Fix #3722.
This was referenced Sep 6, 2020
Closed
Closed
jloehel added a commit to jloehel/python-logstash-async that referenced this issue Sep 27, 2020
@jloehel
Use isort 4.x
f4cd95c 
Pylint is not yet compatible with isort 5.x
For more information please visit:
  * pylint-dev/pylint#3722
  * pylint-dev/pylint#3725

Signed-off-by: Jürgen Löhel <juergen.loehel@inlyse.com>
jloehel added a commit to jloehel/python-logstash-async that referenced this issue Sep 27, 2020
@jloehel
Use isort 4.x
afe28c6 
Pylint is not yet compatible with isort 5.x
For more information please visit:
  * pylint-dev/pylint#3722
  * pylint-dev/pylint#3725

Signed-off-by: Jürgen Löhel <juergen.loehel@inlyse.com>
jloehel added a commit to jloehel/python-logstash-async that referenced this issue Sep 27, 2020
@jloehel
Use isort 4.x
dffdadd 
Pylint is not yet compatible with isort 5.x
For more information please visit:
  * pylint-dev/pylint#3722
  * pylint-dev/pylint#3725

Signed-off-by: Jürgen Löhel <juergen.loehel@inlyse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support both isort 4 and isort 5
Switch to isort 5
6 participants
@kmsquire @sandrotosi @LocutusOfBorg @dekked @limburgher @saroad2