protection against self-assignment

[gitavk]

Based on the SO question it can be good point to add the default check for the self-assignment.
For example

class Aclass:
    def __init__(self, attr=None, attr2=None):
        self.attr = attr
        self.attr2 = attr2

def new_a(attr, attr2):
    a_inst = Aclass()
    a_inst.attr2 = attr2
    # should be: a_inst.attr = attr, but have a typo
    attr = attr
    return a_inst

[PCManticore]

Thanks, this would be good to have!

[chaoflow]

@PCManticore @gitavk The new check catches the following code as erroneous:

FOO = 1

class Bar:
    FOO = FOO

Is this intentional?

[PCManticore]

Looks like an untreated edge case to me, thanks for the ping.

[chaoflow]

@PCManticore Thank you for the quick fix!