Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codebase for Django 3 and Python 3.8 #259

Merged
merged 8 commits into from Feb 11, 2020
Merged

Update codebase for Django 3 and Python 3.8 #259

merged 8 commits into from Feb 11, 2020

Conversation

WayneLambert
Copy link
Contributor

Upgrades to tox.ini, travis.yml and setup.py to run tests against Python 3.8 and Django 3.0

Also, the version number has been bumped in CHANGELOG.rst and my name added in CONTRIBUTORS.md

@coveralls
Copy link

coveralls commented Feb 9, 2020

Pull Request Test Coverage Report for Build 986

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.599%

Totals Coverage Status
Change from base Build 983: 0.0%
Covered Lines: 645
Relevant Lines: 728

💛 - Coveralls

@WayneLambert
Copy link
Contributor Author

Please can you review the pull request? Feel free to make any changes as necessary in order for compatibility with Django 3.0 and Python 3.8.

Does the package's source code or test suite configuration need any further work since Django 3.0 will no longer support Python 2? Some of the failed Travis CI tests seem to be Python 2 specific.

I trust comparing straight to master is OK since there is nothing specific within the contribution guidelines to say otherwise?

Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase to pick up the changes from #260 and squash your commits together.

.travis.yml Outdated Show resolved Hide resolved
CHANGELOG.rst Show resolved Hide resolved
@carlio carlio mentioned this pull request Feb 10, 2020
@carlio
Copy link
Collaborator

carlio commented Feb 10, 2020

This would also need a rebase / merge with master if you could @WayneLambert

Sync Fork to Upstream Repo
Remote date as per request from @atodorov to make it clear it is still unreleased.
@carlio carlio merged commit b85327d into pylint-dev:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants