Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Also allow other toml file readers #599

Closed
q-wertz opened this issue Jun 30, 2022 · 1 comment · Fixed by #608
Closed

Also allow other toml file readers #599

q-wertz opened this issue Jun 30, 2022 · 1 comment · Fixed by #608

Comments

@q-wertz
Copy link

q-wertz commented Jun 30, 2022

Currently when the library toml is missing pydocstyle cannot read the pyproject.toml file.

It would be nice if also other toml reader would be supported (tomli), resp. with python 3.11 the built in tomllib library (which is based on tomli as far as I know).
@codejedi365 codejedi365 mentioned this issue Jul 1, 2022
Closed
mgorny added a commit to mgorny/pydocstyle that referenced this issue Oct 12, 2022
@mgorny
Use tomllib/tomli for reading .toml configs
4fb964b 
Use the built-in `tomllib` module in Python 3.11 and the modern `tomli`
package in older Python versions to read .toml configs instead of
the unmaintained and broken `toml` package.

Fixes PyCQA#599
Fixes PyCQA#600
@mgorny mgorny mentioned this issue Oct 12, 2022
Merged
2 tasks
mgorny added a commit to mgorny/pydocstyle that referenced this issue Oct 12, 2022
@mgorny
Use tomllib/tomli for reading .toml configs
4c9ed77 
Use the built-in `tomllib` module in Python 3.11 and the modern `tomli`
package in older Python versions to read .toml configs instead of
the unmaintained and broken `toml` package.

Fixes PyCQA#599
Fixes PyCQA#600
@adamjstewart
Copy link

Would be better to migrate to tomli since the tomllib module introduced in Python 3.11 uses the same API.

Supporting multiple readers would increase maintenance overhead since they all have different APIs.

mgorny added a commit to mgorny/pydocstyle that referenced this issue Jan 3, 2023
@mgorny
Use tomllib/tomli for reading .toml configs
b45a393 
Use the built-in `tomllib` module in Python 3.11 and the modern `tomli`
package in older Python versions to read .toml configs instead of
the unmaintained and broken `toml` package.

Fixes PyCQA#599
Fixes PyCQA#600
samj1912 added a commit that referenced this issue Jan 3, 2023
@mgorny @samj1912
Use tomllib/tomli for reading .toml configs (#608)
3bc3b87 
Use the built-in `tomllib` module in Python 3.11 and the modern `tomli`
package in older Python versions to read .toml configs instead of
the unmaintained and broken `toml` package.

Fixes #599
Fixes #600

Co-authored-by: Sambhav Kothari <sambhavs.email@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use tomllib/tomli for reading .toml configs mgorny/pydocstyle
2 participants
@adamjstewart @q-wertz