Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Drop support for Python 3.5 #510

Merged
merged 4 commits into from Aug 31, 2020
Merged

Drop support for Python 3.5 #510

merged 4 commits into from Aug 31, 2020

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Aug 31, 2020

Fixes #508.

Also upgrades Python syntax with pyupgrade --py36-plus

And removes D302, which is redundant and cannot be run now Python 2 is dropped.


Thanks for submitting a PR!

Please make sure to check for the following items:

  • Add unit tests and integration tests where applicable.
    If you've added an error code or changed an error code behavior,
    you should probably add or change a test case file under tests/test_cases/ and add
    it to the list under tests/test_definitions.py.
    If you've added or changed a command line option,
    you should probably add or change a test in tests/test_integration.py.
  • Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
    Make sure to include the PR number after you open and get one.

Please don't get discouraged as it may take a while to get a review.

@samj1912
Copy link
Member

I think the first one makes more sense as it also leaves some clues as to why it was deprecated.

@hugovk
Copy link
Contributor Author

hugovk commented Aug 31, 2020

Thanks, updated!

@samj1912 samj1912 merged commit 408f962 into PyCQA:master Aug 31, 2020
@hugovk hugovk deleted the rm-3.5 branch August 31, 2020 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for python 3.5
2 participants