This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Adding tests for parsing one line functions/ Fixing parser bug. #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests look valid but don't pass. from debugging looks like the parser cant find the decorator, although it has no problem finding the function and accepting it as valid.
samj1912
suggested changes
Aug 31, 2020
samj1912
reviewed
Sep 2, 2020
| pass | ||
|
|
||
|
|
||
| @ignored_decorator |
There was a problem hiding this comment.
Can you please add a test case next to this one with a single line definition similar to this one that doesn't have an ignored decorator and raises errors and another one that has a single line definition with a docstring that doesn't raise any errors(again with a non ignored decorator) to check that everything is working as expected in this context?
There was a problem hiding this comment.
Good idea :)
Are the tests I added meet the criteria?
1. oneliner_with_decorator_expecting_errors(): The decorator is not ignored, expecting the D400, D415 errors. 2. valid_oneliner_with_decorator(): A valid one line function that shouldn't produce any errors.
1. oneliner_with_decorator_expecting_errors(): The decorator is not ignored, expecting the D400, D415 errors. 2. valid_oneliner_with_decorator(): A valid one line function that shouldn't produce any errors.
|
@theyuvalraz I see that we forgot to update the release notes for this PR. Can you please add a separate PR that updates them and references this one? |
theyuvalraz
added a commit
to theyuvalraz/pydocstyle
that referenced
this pull request
Sep 14, 2020
theyuvalraz
added a commit
to theyuvalraz/pydocstyle
that referenced
this pull request
Sep 14, 2020
theyuvalraz
added a commit
to theyuvalraz/pydocstyle
that referenced
this pull request
Sep 14, 2020
update release notes for PyCQA#499
theyuvalraz
added a commit
to theyuvalraz/pydocstyle
that referenced
this pull request
Sep 18, 2020
theyuvalraz
added a commit
to theyuvalraz/pydocstyle
that referenced
this pull request
Sep 18, 2020
samj1912
pushed a commit
that referenced
this pull request
Sep 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.