This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Add disable_skip_errors flag to ConventionChecker API #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to ConventionChecker.check_source() and ConventionChecker.check(). This allows other systems that integrate pydocstyle, such as flake8-docstyle, to request errors that are otherwise skipped due to # noqa comments. Added test for skip_errors feature in general and with this flag. Fixes PyCQA#484
sigmavirus24
reviewed
Jun 9, 2020
plinss
force-pushed
the
add-disable-skip-errors
branch
from
7b8ca20
to
65f8d19
Compare
samj1912
reviewed
Jul 5, 2020
samj1912
reviewed
Aug 22, 2020
samj1912
approved these changes
Aug 29, 2020
|
Will release a new minor version tomorrow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to ConventionChecker.check_source() and ConventionChecker.check().
This allows other systems that integrate pydocstyle,
such as flake8-docstyle, to request errors that are otherwise
skipped due to # noqa comments.
Added test for skip_errors feature in general and with this flag.
Fixes #484
Thanks for submitting a PR!
Please make sure to check for the following items:
If you've added an error code or changed an error code behavior,
you should probably add or change a test case file under
tests/test_cases/and addit to the list under
tests/test_definitions.py.If you've added or changed a command line option,
you should probably add or change a test in
tests/test_integration.py.Make sure to include the PR number after you open and get one.
Please don't get discouraged as it may take a while to get a review.