This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Update conventions documentation for v4.0.0 #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses the problem I noted in a comment on issue PyCQA#380
|
Added the command line API documentation update from #386 by @mrshannon |
|
Hey, sorry for the delay in reviews. If you are still interested, can you fix the merge conflicts and update the PR. Thanks! |
samj1912
approved these changes
Mar 6, 2020
samj1912
approved these changes
Mar 6, 2020
samj1912
suggested changes
Mar 6, 2020
docs/release_notes.rst
Outdated
| @@ -66,6 +66,7 @@ Bug Fixes | |||
|
|
|||
| Bug Fixes | |||
|
|
|||
| * Update convention support documentation (#386, #393) | |||
There was a problem hiding this comment.
Looks like you updated the old release notes. Can you add it to the current development version?
There was a problem hiding this comment.
Done. In hindsight I am surprised that wasn't part of the merge conflict.
samj1912
approved these changes
Mar 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the problem I noted in a comment on issue #380
Thanks for submitting a PR!
Please make sure to check for the following items:
If you've added an error code or changed an error code behavior,
you should probably add or change a test case file under
tests/test_cases/and addit to the list under
tests/test_definitions.py.If you've added or changed a command line option,
you should probably add or change a test in
tests/test_integration.py.Make sure to include the PR number after you open and get one.
Please don't get discouraged as it may take a while to get a review.