This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Allow package as an imperative verb in D401 #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a docstring starts with "Package" it's probably something like: ```python """Package the files into a tarball.""" ``` So don't flag it in D401.
gibfahn
force-pushed
the
allow_package_as_an_imperative_verb
branch
from
3382506
to
2a241e2
Compare
|
This didn't seem test-worthy, let me know if it needs one. |
|
@gibfahn can you please rebase this on master? |
samj1912
approved these changes
Aug 31, 2020
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a docstring starts with "Package" it's probably something like:
"""Package the files into a tarball."""So don't flag it in D401.
If you've added an error code or changed an error code behavior,
you should probably add or change a test case file under
tests/test_cases/and addit to the list under
tests/test_definitions.py.If you've added or changed a command line option,
you should probably add or change a test in
tests/test_integration.py.Make sure to include the PR number after you open and get one.