Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tokenize.open to avoid incorrect line endings at beginning of file #976

Merged
merged 1 commit into from Jan 7, 2021
Merged

use tokenize.open to avoid incorrect line endings at beginning of file #976

merged 1 commit into from Jan 7, 2021

Conversation

asottile
Copy link
Member

@asottile asottile commented Jan 7, 2021

Relates to #974

@asottile
Copy link
Member Author

asottile commented Jan 7, 2021

note that the testsuite failed before this with:

$ tox -e py37
GLOB sdist-make: /tmp/z/pycodestyle/setup.py
py37 create: /tmp/z/pycodestyle/.tox/py37
py37 installdeps: coverage
py37 inst: /tmp/z/pycodestyle/.tox/.tmp/package/1/pycodestyle-2.6.0.zip
py37 installed: coverage==5.3.1,pycodestyle @ file:///tmp/z/pycodestyle/.tox/.tmp/package/1/pycodestyle-2.6.0.zip
py37 run-test-pre: PYTHONHASHSEED='3100982836'
py37 run-test: commands[0] | python -m pycodestyle --statistics pycodestyle.py
py37 run-test: commands[1] | coverage run -m pycodestyle --max-doc-length=72 --testsuite testsuite
'estsuite/crlf.py:1:4: W605:1:4 invalid escape sequence '\
3864 lines tested: 40 files, 442 test cases, 1 failures.
Test failed.
ERROR: InvocationError for command /tmp/z/pycodestyle/.tox/py37/bin/coverage run -m pycodestyle --max-doc-length=72 --testsuite testsuite (exited with code 1)
________________________________________ summary ________________________________________
ERROR:   py37: commands failed

@asottile asottile merged commit c47f5c1 into PyCQA:master Jan 7, 2021
@asottile asottile deleted the crlf_at_beginning_of_file branch January 7, 2021 18:35
This was referenced Mar 14, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants