Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E721 false positive #849

Closed
eric-bonfadini opened this issue Mar 1, 2019 · 5 comments
Closed

E721 false positive #849

eric-bonfadini opened this issue Mar 1, 2019 · 5 comments

Comments

@eric-bonfadini
Copy link

With the following code I get a false positive for "E721 do not compare types, use 'isinstance()'".
From my tests, this happens if the function name ends with istype and it has at least two arguments.

def func_histype(arg1, arg2, arg3):
    pass
@sigmavirus24
Copy link
Member

What version are you using? Can you give us any kind of diagnostic information?

@eric-bonfadini
Copy link
Author

pycodestyle --version
2.5.0

@FichteFoll
Copy link
Contributor

FichteFoll commented Mar 1, 2019

I can confirm this on 2.5.0 (and Python 3.7.2).

@asottile
Copy link
Member

asottile commented Mar 1, 2019

try out the branch in #850 🎉

@eric-bonfadini
Copy link
Author

I tried out that branch, and my use case works fine, thanx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants