E225 Check for space around boolean operators #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was documented in the docstring for `missing_whitespace_around_operator` but not implemented, allowing e.g. `1and 0` to pass. Fixed by adding test case then modifying the check to search for the 'and' and 'or' operators as well.
asottile
approved these changes
Feb 28, 2019
| #: E225 | ||
| i = 1and 1 | ||
| #: E225 | ||
| i = 1or 0 |
There was a problem hiding this comment.
here's a few more:
1is 1
1not in []
1in []There was a problem hiding this comment.
Added support for 'is' and 'not', updating for the two-word 'not in' is beyond me right now (07:30 after a long haul flight...)
|
Thanks @asottile for review and @sigmavirus24 for merge! |
|
Thanks for the fix! When you're less jet-lagged and feel like puzzling out |
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was documented in the docstring for
missing_whitespace_around_operatorbut not implemented, allowing e.g.1and 0to pass. Fixed by adding test case then modifying the check to search for the 'and' and 'or' operators as well.