Fix false positive with E741 #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Nov 1, 2022
pycodestyle.py
Outdated
| E741: except AttributeError as O: | ||
| E741: with lock as l: | ||
| E741: global I | ||
| E741: nonlocal l | ||
| E741: def foo(l): | ||
| E741: def foo(l=12): | ||
| E741: l = foo(l=12) | ||
| E741: while l := thing: |
There was a problem hiding this comment.
you'll have to put this in the versioned test file rather than the docstring
There was a problem hiding this comment.
wow, super speedy. you're right, one sec
There was a problem hiding this comment.
I don't think you need the condition you've added -- := will never appear as a token in 3.7
There was a problem hiding this comment.
100%, i was barking up the wrong tree
asottile
reviewed
Nov 1, 2022
testsuite/python38.py
Outdated
| @@ -53,3 +53,5 @@ def f3( | |||
| #: E221:1:6 E221:1:19 | |||
| if (x := 1) == (y := 2): | |||
| pass | |||
| #: E741 | |||
| while l := thing: | |||
There was a problem hiding this comment.
should probably make this valid syntax as well while you're at it
asottile
force-pushed
the
E741-false-pos
branch
from
013e07b
to
a131316
Compare
bkeryan
added a commit
to bkeryan/python-styleguide
that referenced
this pull request
Oct 5, 2023
pycodestyle 2.11 no longer reports E741 - ambiguous variable name for `if l == True` because it doesn't contain an assignment. PyCQA/pycodestyle#1118
mshafer-NI
pushed a commit
to ni/python-styleguide
that referenced
this pull request
Oct 9, 2023
* pyproject.toml: Upgrade flake8 and pycodestyle for Python 3.12 * Update poetry.lock * config: Move inline comments to separate lines for compatibility with flake8 >=6.0 * Coding-Conventions.md: Update E721 example With pycodestyle 2.11, comparing types with `is` is no longer an error: PyCQA/pycodestyle#1084 * tests: Update structural_tests to pass with pycodestyle 2.9 and 2.11 pycodestyle 2.11 no longer reports E741 - ambiguous variable name for `if l == True` because it doesn't contain an assignment. PyCQA/pycodestyle#1118 * PR workflow: Test with Python 3.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noted from #959 (comment) -- we needed to limit this check to assignment operators specifically