Delete W601 -> W604 warnings #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FichteFoll
reviewed
Oct 18, 2022
Comment on lines
-418
to
-424
| | W601 | .has_key() is deprecated, use 'in' | | ||
| +------------+----------------------------------------------------------------------+ | ||
| | W602 | deprecated form of raising exception | | ||
| +------------+----------------------------------------------------------------------+ | ||
| | W603 | '<>' is deprecated, use '!=' | | ||
| +------------+----------------------------------------------------------------------+ | ||
| | W604 | backticks are deprecated, use 'repr()' | |
There was a problem hiding this comment.
Perhaps it should still be mentioned in the documentation that these 4 codes have been in use before and should not be used again for future checks?
There was a problem hiding this comment.
I would just remove them as you've done
There was a problem hiding this comment.
yeah it's unlikely anyone would think to bring them back, since they have to do with the py2 -> py3 transition!
asottile
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1107