Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit E221-E224 for walrus op #1032

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Emit E221-E224 for walrus op #1032

merged 2 commits into from
Oct 13, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Oct 13, 2021

Emit multiple spaces warning before / after assignment expression operator.

#: E221:1:5 E222:1:9 E221:3:6
if x  :=  1:
    pass
if (x  := 2):
    pass
#: E223:1:5 E224:1:8
if x	:=	2:
    pass

asottile
asottile reviewed Oct 13, 2021
View reviewed changes
pycodestyle.py Outdated Show resolved Hide resolved
@cdce8p
Copy link
Member Author

cdce8p commented Oct 13, 2021

The force-push was to add another test case. I didn't expect the PR to be reviewed so soon. Sorry about that.

asottile
asottile approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit abc475c into PyCQA:main Oct 13, 2021
@cdce8p cdce8p deleted the walrus-multiple-spaces branch October 13, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigmavirus24 sigmavirus24 sigmavirus24 approved these changes

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cdce8p @sigmavirus24 @asottile