Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings related to deprecated options syntax #205

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

jparise
Copy link
Member

@jparise jparise commented Jul 15, 2022

These warnings are visible wit flake8 4 and flake8 --verbose:

flake8.options.manager    MainProcess    169 WARNING  option --ignore-names: please update `help=` text to use %(default)s instead of %default -- this will be an error in the future
flake8.options.manager    MainProcess    170 WARNING  option --classmethod-decorators: please update `help=` text to use %(default)s instead of %default -- this will be an error in the future
flake8.options.manager    MainProcess    170 WARNING  option --staticmethod-decorators: please update `help=` text to use %(default)s instead of %default -- this will be an error in the future

Fixes #204

Copy link
Member

@sigmavirus24 sigmavirus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't call them internal warnings. Maybe hidden or silent? Otherwise looks fine

These warnings are visible wit flake8 4 and `flake8 --verbose`:

flake8.options.manager    MainProcess    169 WARNING  option --ignore-names: please update `help=` text to use %(default)s instead of %default -- this will be an error in the future
flake8.options.manager    MainProcess    169 WARNING  option --ignore-names: please update from optparse string `type=` to argparse callable `type=` -- this will be an error in the future
flake8.options.manager    MainProcess    170 WARNING  option --classmethod-decorators: please update `help=` text to use %(default)s instead of %default -- this will be an error in the future
flake8.options.manager    MainProcess    170 WARNING  option --classmethod-decorators: please update from optparse string `type=` to argparse callable `type=` -- this will be an error in the future
flake8.options.manager    MainProcess    170 WARNING  option --staticmethod-decorators: please update `help=` text to use %(default)s instead of %default -- this will be an error in the future
flake8.options.manager    MainProcess    170 WARNING  option --staticmethod-decorators: please update from optparse string `type=` to argparse callable `type=` -- this will be an error in the future
@jparise
Copy link
Member Author

jparise commented Jul 15, 2022

I wouldn't call them internal warnings. Maybe hidden or silent? Otherwise looks fine

I removed the qualifier entirely.

@jparise jparise merged commit e746ff5 into PyCQA:main Jul 15, 2022
@jparise jparise deleted the options-syntax branch July 15, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning for options
2 participants