Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize abc.ABCMeta as a metaclass base type #121

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

jparise
Copy link
Member

@jparise jparise commented Jul 16, 2019

This is a common metaclass base type because it comes from the standard
library. Extend our metaclass detection heuristic (#47) to recognize it.

This is a common metaclass base type because it comes from the standard
library. Extend our metaclass detection heuristic (PyCQA#47) to recognize it.
Copy link
Contributor

@5j9 5j9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not a metaclass expert.

@jparise jparise merged commit 05697b6 into PyCQA:master Jul 17, 2019
@jparise jparise deleted the abcmeta branch July 17, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants