Handle exception assignment to attribute (py2) #115
Merged
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍🏼 |
jparise
reviewed
May 17, 2019
run_tests.py
Outdated
| @@ -99,7 +99,7 @@ def test_file(filename, lines, code, options): | |||
| for lineno, col_offset, msg, instance in checker.run(): | |||
| found_errors.add(error_format(msg.split()[0], **locals())) | |||
|
|
|||
| if not found_errors and code == 'Okay': # Expected PASS | |||
| if not found_errors and code.startswith('Okay'): # Expected PASS | |||
There was a problem hiding this comment.
This change appears to be unrelated?
There was a problem hiding this comment.
Oh, yeah, I originally added a comment to the test to explain it more, but ended up taking it out
There was a problem hiding this comment.
Got it. Could you remove this part of your change then?
There was a problem hiding this comment.
@lordmauve, just wanted to follow up on this. Then I'm happy to merge.
|
Hi, sorry, been on holiday. I'll do this when I get a chance |
lordmauve
force-pushed
the
except-attribute
branch
from
e3640bb
to
4f79156
Compare
jparise
approved these changes
Jun 8, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for a crash in a little-used piece of Python 2 syntax.
Apparently you can assign to an attribute in a Python 2 exception handler:
or (same AST)
Unfortunately pep8-naming doesn't handle this, and crashes with
(It is a SyntaxError in Python 3.)