Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check reStructuredText syntax along with flake8 #108

Merged
merged 1 commit into from Feb 2, 2019

Conversation

jparise
Copy link
Member

@jparise jparise commented Feb 1, 2019

This verifies the integrity of the setup metadata so we can be even more
confident in our PyPI releases.

This verifies the integrity of the setup metadata so we can be even more
confident in our PyPI releases.
@jparise jparise merged commit 2d0e538 into PyCQA:master Feb 2, 2019
@jparise jparise deleted the setup-check-rest branch February 2, 2019 17:34
@sigmavirus24
Copy link
Member

Shouldn't this be twine check at this point? I thought setup.py check --restructuredtext was deprecated.

@jparise
Copy link
Member Author

jparise commented Feb 4, 2019

Shouldn't this be twine check at this point? I thought setup.py check --restructuredtext was deprecated.

Ah, perhaps it is. I see twine check was introduced in version 1.12.0 (September 2018), and I was still using 1.11.0 locally.

@jparise
Copy link
Member Author

jparise commented Feb 4, 2019

twine check appear to only be useful for checking the integrity of a distribution file. It's not good for continuous linting, unless we add a build step which always generates a distribution candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants