Found a dangerous edge case: Comment converted to code

[phil20686]

running isort over the following file:

from math import sqrt

if __name__ == "__main__":
    thing = sqrt(3)
#   some random comments
    from datetime import datetime
    dt = datetime(2020,1,1)

Leads to the comment being converted to code

from math import sqrt

if __name__ == "__main__":
    thing = sqrt(3)
some random comments
    from datetime import datetime
    dt = datetime(2020,1,1)

will be the output. The isort version is 5.10.1. I have not checked all isort versions.

[mawillcockson]

I minimized the original example a bit:

import sys

if True:
#   comment
    import sys

I used this script with git bisect, which pointed to 67b2a54, which is now:

isort/isort/core.py

Lines 415 to 418 in 12cc5fb

	if indent:
	import_section = "".join(
	line[len(indent) :] for line in import_section.splitlines(keepends=True)
	)

[anirudnits]

This is similar to #2087.

[anirudnits]

I'm trying to come up with a solution for this, I added comments on why this is happening and the difficulties I'm facing while resolving them.