Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pycodestyle optional ? #1685

Closed
joaoe opened this issue Sep 15, 2022 · 2 comments
Closed

Make pycodestyle optional ? #1685

joaoe opened this issue Sep 15, 2022 · 2 comments

Comments

@joaoe
Copy link

joaoe commented Sep 15, 2022

Hi.

Black is becoming more and more popular. It is unlikely that developers at this time spend time formatting code manually and instead trust their formating tools to keep formatting consistent (black, autopep8, yapf).

Therefore the dependency on pycodestyle is something many do not need for their projects, while it adds to run time. This is significant for big projects. Despite filtering away all E and W warnings, flake8 will still invoke pycodestyle, and filter warnings after.

So, the suggestion is for flake8 by default not depend on pycodestyle, and only if pycodestyle is installed will flake8 then load and run its pycodestyle plugin.

@asottile
Copy link
Member

#488 is a better approach

I don't necessarily agree with the sentiment though -- there are things which black does not format

@joaoe
Copy link
Author

joaoe commented Sep 16, 2022

there are things which black does not format

True, like long strings or long identifiers, but that does not mean that the developer wants pycodestyle to slowly run through all the code.

@PyCQA PyCQA locked as off-topic and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants