Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit select list ignored if it matches the default list #1604

Closed
duncanmmacleod opened this issue Jun 9, 2022 · 10 comments
Closed

Explicit select list ignored if it matches the default list #1604

duncanmmacleod opened this issue Jun 9, 2022 · 10 comments

Comments

@duncanmmacleod
Copy link

how did you install flake8?

$ conda install -c conda-forge flake8

unmodified output of flake8 --bug-report

{
  "dependencies": [],
  "platform": {
    "python_implementation": "CPython",
    "python_version": "3.10.4",
    "system": "Linux"
  },
  "plugins": [
    {
      "is_local": false,
      "plugin": "flake8-bandit",
      "version": "3.0.0"
    },
    {
      "is_local": false,
      "plugin": "flake8-colors",
      "version": "0.1.9"
    },
    {
      "is_local": false,
      "plugin": "flake8-docstrings",
      "version": "1.6.0, pydocstyle: 6.1.1"
    },
    {
      "is_local": false,
      "plugin": "flake8_isort",
      "version": "4.1.1"
    },
    {
      "is_local": false,
      "plugin": "flake8_quotes",
      "version": "3.3.1"
    },
    {
      "is_local": false,
      "plugin": "import-order",
      "version": "0.18.1"
    },
    {
      "is_local": false,
      "plugin": "mccabe",
      "version": "0.6.1"
    },
    {
      "is_local": false,
      "plugin": "pycodestyle",
      "version": "2.8.0"
    },
    {
      "is_local": false,
      "plugin": "pyflakes",
      "version": "2.4.0"
    },
    {
      "is_local": false,
      "plugin": "radon",
      "version": "5.1.0"
    }
  ],
  "version": "4.0.1"
}

describe the problem

what I expected to happen

When I manually specify --select, it should always be used, even if it happens to match the default select list. Currently if the select list matches the default, it is ignored.

sample code

print("hello world!")

commands ran

$ flake8 --select C90,E,F,W test.py
test.py:1:1: D100 Missing docstring in public module
test.py:1:7: Q000 Double quotes found but single quotes preferred
@asottile
Copy link
Member

asottile commented Jun 9, 2022

dupe #284

@asottile asottile closed this as completed Jun 9, 2022
@duncanmmacleod
Copy link
Author

Sorry for the noise, looks like this has already been fixed, is there a plan for a release to include the fix?

@asottile
Copy link
Member

asottile commented Jun 9, 2022

nope, we never plan to release again

@asottile
Copy link
Member

asottile commented Jun 9, 2022

of course there will be a release

@duncanmmacleod
Copy link
Author

I'm sorry if I'm asking an annoying question.

I ask because the last release was ~9 months ago, and the fix was pushed ~3 months ago, so am wondering if the next release is planned for ~1 week, ~1 month, ~1 year from now (or not 'planned' at all, but will happen eventually)?

This isn't urgent for me, I'm just curious.

@asottile
Copy link
Member

asottile commented Jun 9, 2022

and what would you possibly do with such an answer?

asking for a release is rude, it'll happen when it happens -- if you want to be notified watch the repository

@duncanmmacleod
Copy link
Author

duncanmmacleod commented Jun 9, 2022

@asottile, I'm sorry if I offended, and sorry if I'm now flogging a dead horse. I'm not asking for a release, just curious to know the timeline.

'It'll happen when it happens' is a fine answer for me.

@asottile
Copy link
Member

asottile commented Jun 9, 2022

why are you asking for a timeline?

@duncanmmacleod
Copy link
Author

I am curious to know when I would be able to install a new version of flake8 that doesn't have the problem I reported. It won't impact any schedules or work plans, I'm just curious.

@asottile
Copy link
Member

asottile commented Jun 9, 2022

you can already do that today pip install git+https://github.com/pycqa/flake8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants