New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 621: Migrate to pyproject.toml #291
Conversation
1166126
to
9303d0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks!
- I checked - flake8 is now >= 3.7 so happy to drop 3.6 finally.
Will leave up for at least 24 hours for some others to potentially comment.
with: | ||
python-version: 3.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this default to that or did I break it? Happy to be more explicit here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It used to be REQUIRED but perhaps they fixed it after user complaints. If your mods work then it is now optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/pypa/bandersnatch/blob/main/.github/workflows/pypi_upload.yml#L18 - Ahh seems I did *
here to get latest available python 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would actually autoupgrade to Python 4!!! You are brave. ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, I roll forward and just fix when things break everywhere ... rather than pin and forget to move things like most people seem to prefer to do which I don't get ...
hypothesis | ||
hypothesmith>=0.2 | ||
pre-commit | ||
|
||
[flake8] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't wait for flake8 to support config in the toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My sense is that will take time...
Correct. It will. I was a bit concerned about how long the 3.11 tests take. Co-authored-by: Cooper Lees <me@cooperlees.com>
Migrate to
pyproject.toml
usingini2toml
to do the file conversion and runningvalidate-pyproject
inpre-commit
to validate the results.tool.setuptools.test-suite
which was deprecated insetuptool
v41.5.0flake8
is not compatible withpyproject.toml