Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #263.
... for _ in ...
is OK in a function, even if_
is also a loop variableself.count += 1
does not makeself
a loop variable. I'm generally fine ruling that detecting bugs around attributes is out of scope, but the false-alarms need to be fixedI've run this over our codebase at work (the motivating example 馃槄), and there are only a few false-positives where the function is used and then discarded within the loop iteration that defines it. These cases are also infeasible to reliably detect, so I'm comfortable leaving them to be handled by either manual
var=var
capture or# noqa
comments.