Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore lambda arguments for B020 #259

Merged
merged 2 commits into from May 24, 2022
Merged

Ignore lambda arguments for B020 #259

merged 2 commits into from May 24, 2022

Conversation

NewGlad
Copy link
Contributor

@NewGlad NewGlad commented May 16, 2022 •
edited

cooperlees
cooperlees requested changes May 24, 2022
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this has caused line 21 in b020.py to not raise the error anymore ... I'd like that to still trigger the error ...

Also, black was unhappy.

@NewGlad NewGlad changed the title Ignore "variable.attribute" expression for B020 Ignore lambda arguments for B020 May 24, 2022
@NewGlad NewGlad requested a review from cooperlees May 24, 2022 19:02
cooperlees
cooperlees approved these changes May 24, 2022
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

I’ll happily add to changes once i cut a release in next few weeks.

@cooperlees cooperlees merged commit b1e4ef2 into PyCQA:main May 24, 2022
@FozzieHi FozzieHi mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooperlees cooperlees cooperlees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NewGlad @cooperlees